[PATCH v2 4/6] submodule: change string_list changed_submodule_paths
- From
- Brandon Williams <bmwill@google.com>
- Date
- May 2, 2017, 01:02 UTC
- Message-ID
- <20170502010239.179369-5-bmwill@google.com>
- In-Reply-To
- <20170502010239.179369-1-bmwill@google.com>
Eliminate a call to 'xstrdup()' by changing the string_list 'changed_submodule_paths' to duplicated strings added to it.
Change-Id: Id4b53837a6e209c0c0837c9f5ba06c70df2ffe06 Signed-off-by: Brandon Williams <bmwill@google.com> --- submodule.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/submodule.c b/submodule.c index 7baa28ae0..3bcf44521 100644 --- a/submodule.c +++ b/submodule.c @@ -20,7 +20,7 @@ static int config_fetch_recurse_submodules = RECURSE_SUBMODULES_ON_DEMAND; static int config_update_recurse_submodules = RECURSE_SUBMODULES_DEFAULT; static int parallel_jobs = 1; -static struct string_list changed_submodule_paths = STRING_LIST_INIT_NODUP; +static struct string_list changed_submodule_paths = STRING_LIST_INIT_DUP; static int initialized_fetch_ref_tips; static struct oid_array ref_tips_before_fetch; static struct oid_array ref_tips_after_fetch; @@ -939,7 +939,7 @@ static void submodule_collect_changed_cb(struct diff_queue_struct *q, struct string_list_item *path; path = unsorted_string_list_lookup(&changed_submodule_paths, p->two->path); if (!path && !is_submodule_commit_present(p->two->path, p->two->oid.hash)) - string_list_append(&changed_submodule_paths, xstrdup(p->two->path)); + string_list_append(&changed_submodule_paths, p->two->path); } else { /* Submodule is new or was moved here */ /* NEEDSWORK: When the .git directories of submodules
-- 2.13.0.rc1.294.g07d810a77f-goog