git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xgethostname: handle long hostnames

From
Jeff King <peff@peff.net>
Date
Apr 13, 2017, 21:23 UTC
Message-ID
<20170413212341.cxsd3jzemuu6ec7h@sigill.intra.peff.net>
In-Reply-To
<20170413192335.20679-1-dturner@twosigma.com>
On Thu, Apr 13, 2017 at 03:23:35PM -0400, David Turner wrote:
> If the full hostname doesn't fit in the buffer supplied to
> gethostname, POSIX does not specify whether the buffer will be
> null-terminated

Wow, TIL. What an utterly terrible and error-prone interface (I always just assumed we'd get ENAMETOOLONG, which is what glibc does).

> so to be safe, we should do it ourselves.  Introduce
> new function, xgethostname, which ensures that there is always a \0
> at the end of the buffer.
Your patch looks good to me.
-Peff
Previous: David TurnerNext: Jonathan Nieder
Message 2 of 5 in “xgethostname: handle long hostnames”
  1. xgethostname: handle long hostnamesDavid Turner, Apr 13, 2017
  2. Jeff KingApr 13, 2017
  3. Jonathan NiederApr 13, 2017
  4. David TurnerApr 13, 2017
  5. René ScharfeApr 13, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.