From: Jeff King <peff@peff.net>
Date: Thu, 13 Apr 2017 21:23:41 GMT
Subject: Re: [PATCH] xgethostname: handle long hostnames
Message-ID: <20170413212341.cxsd3jzemuu6ec7h@sigill.intra.peff.net>
In-Reply-To: <20170413192335.20679-1-dturner@twosigma.com>

On Thu, Apr 13, 2017 at 03:23:35PM -0400, David Turner wrote:

> If the full hostname doesn't fit in the buffer supplied to
> gethostname, POSIX does not specify whether the buffer will be
> null-terminated

Wow, TIL. What an utterly terrible and error-prone interface (I always
just assumed we'd get ENAMETOOLONG, which is what glibc does).

> so to be safe, we should do it ourselves.  Introduce
> new function, xgethostname, which ensures that there is always a \0
> at the end of the buffer.

Your patch looks good to me.

-Peff