git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/5] propagating push-options, remote and refspec

From
BWBrandon Williams <bmwill@google.com>
Date
Apr 11, 2017, 16:33 UTC
Message-ID
<20170411163307.GB36152@google.com>
In-Reply-To
<xmqqr30zqtgb.fsf@gitster.mtv.corp.google.com>
On 04/11, Junio C Hamano wrote:
Show 14 quoted lines
> Brandon Williams <bmwill@google.com> writes:
> 
> > v3 builds upon v2 by adding 3 additional patches to add functionality to also
> > propagate the remote and refspec down to children process's working to push
> > submodules.  The remote and refspec will only be propagated if the provided
> > remote is configured. A remote provided in the form of a URL will cause the
> > remote and refspec to not be propagated down to the submodules and instead the
> > default remote and refspec will be used, preserving existing functionality.
> > Currently the only supported LHS of a refspec must exactly match a single ref
> > in the submodule (e.g. a branch name).
> >
> > Patches [1/5] and [2/5] remain unchanged from v2.
> 
> 2/5 seems to be a bit different in 5545 ll.156,+6, though.

Oh, oops you're right. Looks like I forgot that I added a single line to a test in 2/5:

  git -C parent/workbench remote add up ../../upstream &&

Which just configures a remote in one of the submodules. I must have added that to prep for the propagating of the remote/refspec in later patches.

Show 18 quoted lines
> >
> > Brandon Williams (5):
> >   push: unmark a local variable as static
> >   push: propagate push-options with --recurse-submodules
> >   remote: expose parse_push_refspec function
> >   submodule--helper: add push-check subcommand
> >   push: propagate remote and refspec with --recurse-submodules
> >
> >  builtin/push.c                 |  5 +--
> >  builtin/submodule--helper.c    | 45 +++++++++++++++++++++++++
> >  remote.c                       |  2 +-
> >  remote.h                       |  1 +
> >  submodule.c                    | 74 +++++++++++++++++++++++++++++++++++++++---
> >  submodule.h                    |  5 ++-
> >  t/t5531-deep-submodule-push.sh | 52 +++++++++++++++++++++++++++++
> >  t/t5545-push-options.sh        | 40 +++++++++++++++++++++++
> >  transport.c                    |  4 ++-
> >  9 files changed, 219 insertions(+), 9 deletions(-)
-- 
Brandon Williams
Previous: Junio C Hamano
Message 19 of 19 in “push: propagate push-options with --recurse-submodules”
  1. push: propagate push-options with --recurse-submodulesBrandon Williams, Mar 31, 2017
  2. Jonathan NiederMar 31, 2017
  3. Brandon WilliamsMar 31, 2017
  4. 0/2 propagate push-optionsBrandon Williams, Mar 31, 2017
  5. 1/2 push: unmark a local variable as staticBrandon Williams, Mar 31, 2017
  6. Jonathan NiederApr 1, 2017
  7. Brandon WilliamsApr 1, 2017
  8. 2/2 push: propagate push-options with --recurse-submodulesBrandon Williams, Mar 31, 2017
  9. Jonathan NiederApr 1, 2017
  10. Jacob KellerApr 6, 2017
  11. Brandon WilliamsApr 6, 2017
  12. 0/5 propagating push-options, remote and refspecBrandon Williams, Apr 5, 2017
  13. 2/5 push: propagate push-options with --recurse-submodulesBrandon Williams, Apr 5, 2017
  14. 5/5 push: propagate remote and refspec with --recurse-submodulesBrandon Williams, Apr 5, 2017
  15. 4/5 submodule--helper: add push-check subcommandBrandon Williams, Apr 5, 2017
  16. 1/5 push: unmark a local variable as staticBrandon Williams, Apr 5, 2017
  17. 3/5 remote: expose parse_push_refspec functionBrandon Williams, Apr 5, 2017
  18. Junio C HamanoApr 11, 2017
  19. Brandon WilliamsApr 11, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.