[PATCH v2 1/2] push: unmark a local variable as static
- From
- Brandon Williams <bmwill@google.com>
- Date
- Mar 31, 2017, 23:56 UTC
- Message-ID
- <20170331235623.166408-2-bmwill@google.com>
- In-Reply-To
- <20170331235623.166408-1-bmwill@google.com>
There isn't any obvious reason for the 'struct string_list push_options' and 'struct string_list_item *item' to be marked as static, so unmark them as being static. Also, clear the push_options string_list to prevent memory leaking.
Signed-off-by: Brandon Williams <bmwill@google.com> --- builtin/push.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin/push.c b/builtin/push.c index 5c22e9f2e..a597759d8 100644 --- a/builtin/push.c +++ b/builtin/push.c @@ -510,8 +510,8 @@ int cmd_push(int argc, const char **argv, const char *prefix) int push_cert = -1; int rc; const char *repo = NULL; /* default repository */ - static struct string_list push_options = STRING_LIST_INIT_DUP; - static struct string_list_item *item; + struct string_list push_options = STRING_LIST_INIT_DUP; + const struct string_list_item *item; struct option options[] = { OPT__VERBOSITY(&verbosity), @@ -584,6 +584,7 @@ int cmd_push(int argc, const char **argv, const char *prefix) die(_("push options must not have new line characters")); rc = do_push(repo, flags, &push_options); + string_list_clear(&push_options, 0); if (rc == -1) usage_with_options(push_usage, options); else
-- 2.12.2.564.g063fe858b8-goog