git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Apr 5, 2017, 22:47 UTC
Message-ID
<20170405224752.2242-1-szeder.dev@gmail.com>
In-Reply-To
<20170405173809.3098-4-git@jeffhostetler.com>

I think this patch should be squashed into the previous commit; I don't see any reason why the tests should be added in a different commit than the function they are testing. However...

Show 9 quoted lines
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> ---
>  Makefile                      |  1 +
>  t/helper/.gitignore           |  1 +
>  t/helper/test-strcmp-offset.c | 64 +++++++++++++++++++++++++++++++++++++++++++
>  t/t0065-strcmp-offset.sh      | 11 ++++++++
>  4 files changed, 77 insertions(+)
>  create mode 100644 t/helper/test-strcmp-offset.c
>  create mode 100755 t/t0065-strcmp-offset.sh

Sure, tests are good, but I have to wonder how this would scale in the long term, when even such simple functions would get their own t/helper/test-func executable and t/tNNNN-func.sh script.

Previous: git@jeffhostetler.comNext: Johannes Schindelin
Message 6 of 16 in “read-cache: speed up add_index_entry”
  1. 0/4 read-cache: speed up add_index_entrygit@jeffhostetler.com, Apr 5, 2017
  2. 4/4 read-cache: speed up add_index_entry during checkoutgit@jeffhostetler.com, Apr 5, 2017
  3. SZEDER GáborApr 5, 2017
  4. Jeff HostetlerApr 6, 2017
  5. 3/4 test-strcmp-offset: created test for strcmp_offsetgit@jeffhostetler.com, Apr 5, 2017
  6. SZEDER GáborApr 5, 2017
  7. Johannes SchindelinApr 6, 2017
  8. Jeff HostetlerApr 6, 2017
  9. René ScharfeApr 6, 2017
  10. Jeff HostetlerApr 6, 2017
  11. 1/4 p0004-read-tree: perf test to time read-treegit@jeffhostetler.com, Apr 5, 2017
  12. René ScharfeApr 6, 2017
  13. Jeff HostetlerApr 6, 2017
  14. 2/4 read-cache: add strcmp_offset functiongit@jeffhostetler.com, Apr 5, 2017
  15. SZEDER GáborApr 6, 2017
  16. Jeff HostetlerApr 6, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.