From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Wed, 05 Apr 2017 22:47:52 GMT
Subject: Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset
Message-ID: <20170405224752.2242-1-szeder.dev@gmail.com>
In-Reply-To: <20170405173809.3098-4-git@jeffhostetler.com>

I think this patch should be squashed into the previous commit;  I
don't see any reason why the tests should be added in a different
commit than the function they are testing.  However...

> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> ---
>  Makefile                      |  1 +
>  t/helper/.gitignore           |  1 +
>  t/helper/test-strcmp-offset.c | 64 +++++++++++++++++++++++++++++++++++++++++++
>  t/t0065-strcmp-offset.sh      | 11 ++++++++
>  4 files changed, 77 insertions(+)
>  create mode 100644 t/helper/test-strcmp-offset.c
>  create mode 100755 t/t0065-strcmp-offset.sh

Sure, tests are good, but I have to wonder how this would scale in the
long term, when even such simple functions would get their own
t/helper/test-func executable and t/tNNNN-func.sh script.