Re: [PATCH 0/18] snprintf cleanups

From: Jeff King <peff@peff.net>
Date: Mar 30, 2017, 06:27 UTC
Message-ID: <20170330062730.ycsok7skrjy5c6en@sigill.intra.peff.net>
In-Reply-To: <xmqqr31gax0y.fsf@gitster.mtv.corp.google.com>

On Wed, Mar 29, 2017 at 09:05:33AM -0700, Junio C Hamano wrote:

Show 18 quoted lines

> > I think there are two things going on in your example.
> >
> > One is that obviously patch_id_addf() removes the spaces from the
> > result. But we could do that now by keeping the big strbuf_addf(), and
> > then just walking the result and feeding non-spaces.
> >
> > The second is that your addf means we are back to formatting everything
> > into a buffer again....
> 
> You are right to point out that I was blinded by the ugliness of
> words stuck together without spaces in between, which was inherited
> from the original code, and failed to see the sole point of this
> series, which is to remove truncation without adding unnecessary
> allocation and freeing.
> 
> Thanks for straighten my thinking out.  I think the seeming
> ugliness, if it ever becomes a real problem, should be handled
> outside this series after the dust settles.

Yeah, the no-spaces thing should almost certainly wait.

There is still the minor question of whether skipping the strbuf entirely is nicer, even if you still have to feed it strings without spaces (i.e., what I posted in my initial reply).

I'm OK either with the series I posted, or wrapping up the alternative in a commit message.

-Peff