[PATCH 16/18] transport-helper: replace checked snprintf with xsnprintf
- From
Jeff King <peff@peff.net>
- Date
- Mar 28, 2017, 19:47 UTC
- Message-ID
- <20170328194700.yowtm7sg55loyhdg@sigill.intra.peff.net>
- In-Reply-To
- <20170328194255.vf7nfzzmmzxsbn36@sigill.intra.peff.net>
We can use xsnprintf to do our truncation check with less code. The error message isn't as specific, but the point is that this isn't supposed to trigger in the first place (because our buffer is big enough to handle any int).
Signed-off-by: Jeff King <peff@peff.net> --- transport-helper.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c index dc90a1fb7..36408046e 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -347,14 +347,11 @@ static int set_helper_option(struct transport *transport, static void standard_options(struct transport *t) { char buf[16]; - int n; int v = t->verbose; set_helper_option(t, "progress", t->progress ? "true" : "false"); - n = snprintf(buf, sizeof(buf), "%d", v + 1); - if (n >= sizeof(buf)) - die("impossibly large verbosity value"); + xsnprintf(buf, sizeof(buf), "%d", v + 1); set_helper_option(t, "verbosity", buf); switch (t->family) {
-- 2.12.2.845.g55fcf8b10