Re: [PATCH v2 16/21] Make sha1_array_append take a struct object_id *
On Sun, Mar 26, 2017 at 04:01:38PM +0000, brian m. carlson wrote:
Show 11 quoted lines
> diff --git a/transport.c b/transport.c
> index 8a90b0c29b..e492757726 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -1027,7 +1027,8 @@ int transport_push(struct transport *transport,
>
> for (; ref; ref = ref->next)
> if (!is_null_oid(&ref->new_oid))
> - sha1_array_append(&commits, ref->new_oid.hash);
> + sha1_array_append(&commits,
> + &ref->new_oid);
Funny that this line wrapped when it got shorter. :)
I think wrapping is the right thing, though (it is longer than 80).
-Peff