Re: [PATCH 1/2] send-pack: send push options correctly in stateless-rpc case
On 03/22, Jonathan Nieder wrote:
Show 19 quoted lines
> Brandon Williams wrote:
>
> > "git send-pack --stateless-rpc" puts each request in a sequence of pkt-lines
> > followed by a flush-pkt. The push option code forgot about this and sends push
> > options and their terminating delimiter as ordinary pkt-lines that get their
> > length header stripped off by remote-curl before being sent to the server.
> >
> > The result is multiple malformed requests, which the server rejects.
> >
> > Fortunately send-pack --stateless-rpc already is aware of this "pkt-line within
> > pkt-line" framing for the update commands that precede push options. Handle
> > push options the same way.
> >
> > Signed-off-by: Brandon Williams <bmwill@google.com>
> > ---
> > send-pack.c | 20 ++++++++------------
> > 1 file changed, 8 insertions(+), 12 deletions(-)
>
> This is only a hypothetical issue until the next patch though, right?
Correct, Its in preparation for the next patch.
Show 7 quoted lines
>
> For what it's worth,
>
> Tested-by: Jonathan Nieder <jrnieder@gmail.com>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks.
--
Brandon Williams