git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] send-pack: send push options correctly in stateless-rpc case

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 22, 2017, 21:15 UTC
Message-ID
<20170322211546.GB26108@aiede.mtv.corp.google.com>
In-Reply-To
<20170322195102.165314-2-bmwill@google.com>
Brandon Williams wrote:
Show 15 quoted lines
> "git send-pack --stateless-rpc" puts each request in a sequence of pkt-lines
> followed by a flush-pkt. The push option code forgot about this and sends push
> options and their terminating delimiter as ordinary pkt-lines that get their
> length header stripped off by remote-curl before being sent to the server.
>
> The result is multiple malformed requests, which the server rejects.
>
> Fortunately send-pack --stateless-rpc already is aware of this "pkt-line within
> pkt-line" framing for the update commands that precede push options. Handle
> push options the same way.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  send-pack.c | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
This is only a hypothetical issue until the next patch though, right?
For what it's worth,
Tested-by: Jonathan Nieder <jrnieder@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
Previous: Brandon WilliamsNext: Brandon Williams
Message 8 of 15 in “push options across http”
  1. 0/2 push options across httpBrandon Williams, Mar 22, 2017
  2. 2/2 remote-curl: allow push optionsBrandon Williams, Mar 22, 2017
  3. Junio C HamanoMar 22, 2017
  4. Brandon WilliamsMar 22, 2017
  5. Jonathan NiederMar 22, 2017
  6. Brandon WilliamsMar 22, 2017
  7. 1/2 send-pack: send push options correctly in stateless-rpc caseBrandon Williams, Mar 22, 2017
  8. Jonathan NiederMar 22, 2017
  9. Brandon WilliamsMar 22, 2017
  10. Junio C HamanoMar 22, 2017
  11. Stefan BellerMar 22, 2017
  12. 0/2 push options across httpBrandon Williams, Mar 22, 2017
  13. 1/2 send-pack: send push options correctly in stateless-rpc caseBrandon Williams, Mar 22, 2017
  14. 2/2 remote-curl: allow push optionsBrandon Williams, Mar 22, 2017
  15. Jonathan NiederMar 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.