Re: [PATCH 2/2] revparse: introduce --is-inside-working-tree

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 20, 2017, 20:00 UTC
Message-ID: <20170320200052.GW26789@aiede.mtv.corp.google.com>
In-Reply-To: <20170320192225.18928-3-sbeller@google.com>

Hi,

Stefan Beller wrote:

Show 8 quoted lines

> This behaves the same as 'is-inside-worktree' and supersedes it.
> See prior patch for discussion of "working tree" vs. "worktree"
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  Documentation/git-rev-parse.txt | 4 ++--
>  builtin/rev-parse.c             | 3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)

This is less invasive than the previous patch and can probably stand alone. Some of the same nits apply:

* tests?

* documentation would need to warn people that this option is new, for
  now. In fact it's even tempting to make --is-inside-working-tree
  the hidden/discouraged one for a while, until script authors can
  count on git having had it available for a while, and only then
  encourage its use.

Thanks and hope that helps, Jonathan