git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] Makefile: add USE_SHA1DC knob

From
Jeff King <peff@peff.net>
Date
Mar 17, 2017, 00:11 UTC
Message-ID
<20170317001115.xau6nzp6i7ilkqxv@sigill.intra.peff.net>
In-Reply-To
<xmqqtw6salmm.fsf@gitster.mtv.corp.google.com>
On Thu, Mar 16, 2017 at 03:43:13PM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > +ifdef USE_SHA1DC
> > +	LIB_OBJS += sha1dc/sha1.o
> > +	LIB_OBJS += sha1dc/ubc_check.o
> > +	BASIC_CFLAGS += -DSHA1_SHA1DC
> 
> The name of this CPP symbol is one difference between this and
> Linus's version.  Wouldn't "-DSHA1_DC" make more sense?

I'm fine with either. Somehow SHA1_DC felt too short, but it doesn't really matter in practice.

Show 5 quoted lines
> Another difference is that your version adds USE_SHA1DC to
> GIT-BUILD-OPTIONS in patch 5/5; I thought GIT-CFLAGS forces
> rebuilding and that was sufficient, but GIT-BUILD-OPTIONS is
> available to tests for introspection, so adding it is needed
> for that reason.
Yep, exactly.
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 20 in “Re-integrate sha1dc”
  1. 0/2 Re-integrate sha1dcLinus Torvalds, Mar 16, 2017
  2. Jeff KingMar 16, 2017
  3. 2/5 sha1dc: adjust header includes for gitJeff King, Mar 16, 2017
  4. 3/5 sha1dc: disable safe_hash featureJeff King, Mar 16, 2017
  5. 4/5 Makefile: add USE_SHA1DC knobJeff King, Mar 16, 2017
  6. Junio C HamanoMar 16, 2017
  7. Jeff KingMar 17, 2017
  8. Junio C HamanoMar 17, 2017
  9. Jeff KingMar 17, 2017
  10. 0/3 Git integration update for DC-SHA1Junio C Hamano, Mar 17, 2017
  11. 1/3 Makefile: add DC_SHA1 knobJunio C Hamano, Mar 17, 2017
  12. 3/3 Makefile: make DC_SHA1 the defaultJunio C Hamano, Mar 17, 2017
  13. Junio C HamanoMar 17, 2017
  14. Jeff KingMar 17, 2017
  15. Jeff KingMar 16, 2017
  16. Junio C HamanoMar 16, 2017
  17. Jeff KingMar 17, 2017
  18. Junio C HamanoMar 17, 2017
  19. Jeff KingMar 17, 2017
  20. Linus TorvaldsMar 16, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.