From: Jeff King <peff@peff.net>
Date: Fri, 17 Mar 2017 00:11:16 GMT
Subject: Re: [PATCH 4/5] Makefile: add USE_SHA1DC knob
Message-ID: <20170317001115.xau6nzp6i7ilkqxv@sigill.intra.peff.net>
In-Reply-To: <xmqqtw6salmm.fsf@gitster.mtv.corp.google.com>

On Thu, Mar 16, 2017 at 03:43:13PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > +ifdef USE_SHA1DC
> > +	LIB_OBJS += sha1dc/sha1.o
> > +	LIB_OBJS += sha1dc/ubc_check.o
> > +	BASIC_CFLAGS += -DSHA1_SHA1DC
> 
> The name of this CPP symbol is one difference between this and
> Linus's version.  Wouldn't "-DSHA1_DC" make more sense?

I'm fine with either. Somehow SHA1_DC felt too short, but it doesn't
really matter in practice.

> Another difference is that your version adds USE_SHA1DC to
> GIT-BUILD-OPTIONS in patch 5/5; I thought GIT-CFLAGS forces
> rebuilding and that was sufficient, but GIT-BUILD-OPTIONS is
> available to tests for introspection, so adding it is needed
> for that reason.

Yep, exactly.

-Peff