git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add--interactive: do not expand pathspecs with ls-files

From
Jeff King <peff@peff.net>
Date
Mar 14, 2017, 16:31 UTC
Message-ID
<20170314163156.qhfvdphqohbexm4h@sigill.intra.peff.net>
In-Reply-To
<20170314163024.et2cp5e3imrrrf7k@sigill.intra.peff.net>
On Tue, Mar 14, 2017 at 12:30:24PM -0400, Jeff King wrote:
Show 10 quoted lines
>   2. Even when it does work, it's really slow. The pathspec
>      code is not optimized for huge numbers of paths. Here's
>      the same case without the ulimit:
> 
>        $ time git add -p drivers
>        No changes.
> 
>        real	0m16.559s
>        user	0m53.140s
>        sys	0m0.220s

By the way, I wondered how we managed to consume more CPU than wall-clock time. I think the answer is that diff-files does the pathspec matching during the threaded preload stage.

-Peff
Previous: Jeff KingNext: Brandon Williams
Message 2 of 6 in “add--interactive: do not expand pathspecs with ls-files”
  1. add--interactive: do not expand pathspecs with ls-filesJeff King, Mar 14, 2017
  2. Jeff KingMar 14, 2017
  3. Brandon WilliamsMar 14, 2017
  4. Jeff KingMar 14, 2017
  5. Junio C HamanoMar 14, 2017
  6. Jeff KingMar 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.