From: Jeff King <peff@peff.net>
Date: Tue, 14 Mar 2017 16:31:56 GMT
Subject: Re: [PATCH] add--interactive: do not expand pathspecs with ls-files
Message-ID: <20170314163156.qhfvdphqohbexm4h@sigill.intra.peff.net>
In-Reply-To: <20170314163024.et2cp5e3imrrrf7k@sigill.intra.peff.net>

On Tue, Mar 14, 2017 at 12:30:24PM -0400, Jeff King wrote:

>   2. Even when it does work, it's really slow. The pathspec
>      code is not optimized for huge numbers of paths. Here's
>      the same case without the ulimit:
> 
>        $ time git add -p drivers
>        No changes.
> 
>        real	0m16.559s
>        user	0m53.140s
>        sys	0m0.220s

By the way, I wondered how we managed to consume more CPU than
wall-clock time. I think the answer is that diff-files does the pathspec
matching during the threaded preload stage.

-Peff