Re: [PATCH 02/10] pack-objects: add --partial-by-size=n --partial-special

From: Jeff King <peff@peff.net>
Date: Mar 10, 2017, 19:47 UTC
Message-ID: <20170310194725.36acsc2bdfhl4aih@sigill.intra.peff.net>
In-Reply-To: <xmqqzigsylb1.fsf@gitster.mtv.corp.google.com>

On Fri, Mar 10, 2017 at 11:38:10AM -0800, Junio C Hamano wrote:

Show 9 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I think we ended up deciding that it would be better to just disallow
> > symlink .gitattributes (and .git*) from entering the index, the way we
> > disallow ".git".
> 
> Hmph, I thought we would need both, though.  Or do we specifically
> want to honor untracked .gitattributes that is left as a symlink
> pointing to elsewhere in the filesystem or something like that?

I wasn't going to worry about an untracked .gitattributes. The reasons for disallowing symlinked .gitattributes are:

  - it doesn't behave the same when accessed internally via the tree
    objects

  - malicious symlinks that try to leave the repository

Neither of those issues is at play if your symlink .gitattributes file isn't tracked. So there's some inconsistency in the sense that it "works" until you try to "git add" it. But either you aren't going to add it (in which case it's a feature that it works), or you are going to add it, and you'll get notified then that it's disallowed.

-Peff