Re: [PATCH 02/10] pack-objects: add --partial-by-size=n --partial-special
- From
Jeff King <peff@peff.net>
- Date
- Mar 10, 2017, 18:03 UTC
- Message-ID
- <20170310180341.bbzukqrj2zlkje2b@sigill.intra.peff.net>
- In-Reply-To
- <20170310175823.GA53198@google.com>
On Fri, Mar 10, 2017 at 09:58:23AM -0800, Brandon Williams wrote:
Show 7 quoted lines
> > A while back when we discussed whether to allow symlinks for > > .gitattributes, etc, I think the consensus was to treat the whole > > ".git*" namespace consistently. I haven't followed up with patches yet, > > but my plan was to go that route. > > Well if I remember correctly you sent out some patches for > .gitattributes but I got in the way with the refactoring work! :)
True. :) But those were the old method that tries to treat .gitattributes specially, by using O_NOFOLLOW in the attribute code (but only for in-tree files, naturally).
I think we ended up deciding that it would be better to just disallow symlink .gitattributes (and .git*) from entering the index, the way we disallow ".git".
-Peff