git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] blame: move blame_entry duplication to add_blame_entry()

From
Jeff King <peff@peff.net>
Date
Mar 10, 2017, 08:32 UTC
Message-ID
<20170310083238.hjfnkmcgufi3oehq@sigill.intra.peff.net>
In-Reply-To
<11b8ad3a-cd3d-2fd6-4b06-b442099c2709@web.de>
On Fri, Mar 10, 2017 at 01:12:59AM +0100, René Scharfe wrote:
> All callers of add_blame_entry() allocate and copy the second argument.
> Let the function do it for them, reducing code duplication.

I assume you found this due to the DUPLICATE() discussion elsewhere. Regardless of the results of that discussion, I think this is a nice simplification.

-Peff
Previous: René ScharfeNext: René Scharfe
Message 2 of 3 in “blame: move blame_entry duplication to add_blame_entry()”
  1. blame: move blame_entry duplication to add_blame_entry()René Scharfe, Mar 10, 2017
  2. Jeff KingMar 10, 2017
  3. René ScharfeMar 10, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.