[PATCH 3/4] ref-filter: die on parse_commit errors

From: Jeff King <peff@peff.net>
Date: Mar 9, 2017, 13:29 UTC
Message-ID: <20170309132903.om7b2uvn6vsvjiwt@sigill.intra.peff.net>
In-Reply-To: <20170309132728.c57ltzel746l366a@sigill.intra.peff.net>

The tag-contains algorithm quietly returns "does not contain" when parse_commit() fails. But a parse failure is an indication that the repository is corrupt. We should die loudly rather than producing a bogus result.

Signed-off-by: Jeff King <peff@peff.net>
---
 ref-filter.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ref-filter.c b/ref-filter.c
index 631978a4f..5cb49b7c2 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1523,9 +1523,7 @@ static enum contains_result contains_test(struct commit *candidate,
 		return CONTAINS_YES;
 	}
 
-	if (parse_commit(candidate) < 0)
-		return CONTAINS_NO;
-
+	parse_commit_or_die(candidate);
 	return CONTAINS_UNKNOWN;
 }

-- 
2.12.0.445.g818af77e0