[PATCH 0/4] fix object flag pollution in "tag --contains"

From: Jeff King <peff@peff.net>
Date: Mar 9, 2017, 13:27 UTC
Message-ID: <20170309132728.c57ltzel746l366a@sigill.intra.peff.net>
In-Reply-To: <20170309125132.tubwxtneffok4nrc@sigill.intra.peff.net>

On Thu, Mar 09, 2017 at 07:51:32AM -0500, Jeff King wrote:

> Looking at this, I'm pretty sure that using "--contains" with "--merged"
> has similar problems, as they both use the UNINTERESTING bit. So even
> without your patch, there is a lurking bug.

I wasn't able to come up with a simple case that actually demonstrates the bug. But I feel like it has to be triggerable with the right sequence of history.

Even without that, though, I feel like moving away from this flag usage is a good cleanup. Here's a cleaned-up series. What do you think of building your patch on top?

We can do it the other way around if you prefer.

  [1/4]: ref-filter: move ref_cbdata definition into ref-filter.c
  [2/4]: ref-filter: use contains_result enum consistently
  [3/4]: ref-filter: die on parse_commit errors
  [4/4]: ref-filter: use separate cache for contains_tag_algo

 ref-filter.c | 70 ++++++++++++++++++++++++++++++++++++++----------------------
 ref-filter.h |  5 -----
 2 files changed, 44 insertions(+), 31 deletions(-)

-Peff