git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] wrapper.c: remove unused git_mkstemp() function

From
Jeff King <peff@peff.net>
Date
Feb 28, 2017, 13:12 UTC
Message-ID
<20170228131255.ufpoexm55ovpwka3@sigill.intra.peff.net>
In-Reply-To
<976c40d1-42dc-1fc5-45d5-05bdcf04d97e@ramsayjones.plus.com>
On Tue, Feb 28, 2017 at 01:24:10AM +0000, Ramsay Jones wrote:
Show 5 quoted lines
> The last caller of git_mkstemp() was removed in commit 6fec0a89
> ("verify_signed_buffer: use tempfile object", 16-06-2016). Since
> the introduction of the 'tempfile' APIs, along with git_mkstemp_mode,
> it is unlikely that new callers will materialize. Remove the dead
> code.

Yeah, I think the tempfile API is a better choice for anybody who wants to add a new call. Removing the temptation (and the dead code) is a good move.

-Peff
Previous: Ramsay Jones
Message 2 of 2 in “wrapper.c: remove unused git_mkstemp() function”
  1. 1/2 wrapper.c: remove unused git_mkstemp() functionRamsay Jones, Feb 28, 2017
  2. Jeff KingFeb 28, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.