From: Jeff King <peff@peff.net>
Date: Tue, 28 Feb 2017 13:12:56 GMT
Subject: Re: [PATCH 1/2] wrapper.c: remove unused git_mkstemp() function
Message-ID: <20170228131255.ufpoexm55ovpwka3@sigill.intra.peff.net>
In-Reply-To: <976c40d1-42dc-1fc5-45d5-05bdcf04d97e@ramsayjones.plus.com>

On Tue, Feb 28, 2017 at 01:24:10AM +0000, Ramsay Jones wrote:

> The last caller of git_mkstemp() was removed in commit 6fec0a89
> ("verify_signed_buffer: use tempfile object", 16-06-2016). Since
> the introduction of the 'tempfile' APIs, along with git_mkstemp_mode,
> it is unlikely that new callers will materialize. Remove the dead
> code.

Yeah, I think the tempfile API is a better choice for anybody who wants
to add a new call. Removing the temptation (and the dead code) is a good
move.

-Peff