Re: What's cooking in git.git (Feb 2017, #02; Mon, 6)

From: Jeff King <peff@peff.net>
Date: Feb 9, 2017, 03:46 UTC
Message-ID: <20170209034657.qbkzbbzuvjpxl422@sigill.intra.peff.net>
In-Reply-To: <xmqqzihzymn3.fsf@gitster.mtv.corp.google.com>

On Mon, Feb 06, 2017 at 02:34:08PM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> * sk/parse-remote-cleanup (2017-02-06) 1 commit
>   (merged to 'next' on 2017-02-06 at 6ec89f72d5)
>  + parse-remote: remove reference to unused op_prep
> 
>  Code clean-up.
> 
>  Will merge to 'master'.

Hrm. Are the functions in git-parse-remote.sh part of the public API? That is, do we expect third-party scripts to do:

  . "$(git rev-parse --exec)/git-parse-remote.sh
  error_on_missing_default_upstream "$a" "$b" "$c" "$d"

? If so, then they may be surprised by the change in function signature.

I generally think of git-sh-setup as the one that external scripts would use. There _is_ a manpage for git-parse-remote, but it doesn't list any functions. So maybe they're all fair game for changing?

I just didn't see any discussion of this in the original patch thread, so I wanted to make sure we were making that decision consciously, and not accidentally. :)

-Peff