Re: [PATCH v2 1/1] reset: support the --stdin option

From: Jeff King <peff@peff.net>
Date: Jan 27, 2017, 17:54 UTC
Message-ID: <20170127175422.b7bds4toeytndo43@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.20.1701271832270.3469@virtualbox>

On Fri, Jan 27, 2017 at 06:34:46PM +0100, Johannes Schindelin wrote:

Show 8 quoted lines

> > Is it worth clarifying that these are paths, not pathspecs? The word
> > "paths" is used to refer to the pathspecs on the command-line elsewhere
> > in the document.
> > 
> > It might also be worth mentioning the quoting rules for the non-z case.
> 
> I think this would be overkill. In reality, --stdin without -z does not
> make much sense, anyway.

I think with most Unix tools people tend to use the non-z forms until they break, and then switch to the z form. :)

And in that sense, this transparently Just Works because the output will often come from another git tool, which will quote as appropriate.

> If you feel strongly about it, I encourage you to submit a follow-up
> patch.
> 
> The rest of your suggestions have been implemented in v3.

Thanks. I think the path/pathspec thing was the more important of the two suggestions.

-Peff