Re: [PATCH 0/2] Support `git reset --stdin`

From: Jeff King <peff@peff.net>
Date: Oct 11, 2016, 21:26 UTC
Message-ID: <20161011212644.zzqidtcgatu3qsei@sigill.intra.peff.net>
In-Reply-To: <xmqqshs28z52.fsf@gitster.mtv.corp.google.com>

On Tue, Oct 11, 2016 at 12:27:21PM -0700, Junio C Hamano wrote:

Show 17 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > Is git-reset the right layer to add scripting features? I thought we
> > usually pushed people doing mass index manipulation to use update-index
> > or read-tree. Is there something that reset makes easy that is hard with
> > those tools (I could imagine "--hard", but I see it is not supported
> > with your patch).
> >
> > Not that I'm necessarily opposed to the patch, I was just surprised.
> 
> If read-tree had pathspec support (i.e. "read these and only these
> paths given from the command line into the index from a given
> tree-ish"), that would have been the most natural place to extend
> with "oh, by the way, instead of the command line, you can feed the
> paths on the standard input".
> 
> But it doesn't have one.

True. I'd have done something more like:

  git ls-tree -r $paths | git update-index --index-info

but there are some corner cases around deleting paths from the index.

-Peff