Re: [PATCH 1/6] t1450: clean up sub-objects in duplicate-entry test

From: Jeff King <peff@peff.net>
Date: Jan 17, 2017, 20:53 UTC
Message-ID: <20170117205354.wiczgyplbgsurn6e@sigill.intra.peff.net>
In-Reply-To: <xmqqlgu9e7dw.fsf@gitster.mtv.corp.google.com>

On Tue, Jan 17, 2017 at 12:52:43PM -0800, Junio C Hamano wrote:

Show 14 quoted lines

> > Since the setup code happens inside a subshell, we can't
> > just set a variable for each object. However, we can stuff
> > all of the sha1s into the $T output variable, which is not
> > used for anything except cleanup.
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> >  t/t1450-fsck.sh | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Thanks.  
> 
> It is tempting to move this loop to remove_object, but that is not
> necessary while the user is only this one.

I agree it would be less gross. I avoided it because I knew that I hacked up remove_object() in the other topic.

-Peff