git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] submodule.c: use GIT_DIR_ENVIRONMENT consistently

From
Jeff King <peff@peff.net>
Date
Jan 4, 2017, 01:18 UTC
Message-ID
<20170104011841.bpoiqvi5hqsdqu7y@sigill.intra.peff.net>
In-Reply-To
<20170103183047.17968-1-sbeller@google.com>
On Tue, Jan 03, 2017 at 10:30:47AM -0800, Stefan Beller wrote:
Show 5 quoted lines
> In C code we have the luxury of having constants for all the important
> things that are hard coded. This is the only place in C, that hard codes
> the git directory environment variable, so fix it.
> 
> Signed-off-by: Stefan Beller <sbeller@google.com>
This looks like a good change to me.
Minor nit: the comma after "C" in your commit message is extraneous. ;)
-Peff
Previous: Stefan Beller
Message 4 of 4 in “submodule.c: use GIT_DIR_ENVIRONMENT consistently”
  1. submodule.c: use GIT_DIR_ENVIRONMENT consistentlyStefan Beller, Dec 30, 2016
  2. René ScharfeDec 30, 2016
  3. [PATCHv2] submodule.c: use GIT_DIR_ENVIRONMENT consistentlyStefan Beller, Jan 3, 2017
  4. Jeff KingJan 4, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.