From: Jeff King <peff@peff.net>
Date: Wed, 04 Jan 2017 01:18:41 GMT
Subject: Re: [PATCHv2] submodule.c: use GIT_DIR_ENVIRONMENT consistently
Message-ID: <20170104011841.bpoiqvi5hqsdqu7y@sigill.intra.peff.net>
In-Reply-To: <20170103183047.17968-1-sbeller@google.com>

On Tue, Jan 03, 2017 at 10:30:47AM -0800, Stefan Beller wrote:

> In C code we have the luxury of having constants for all the important
> things that are hard coded. This is the only place in C, that hard codes
> the git directory environment variable, so fix it.
> 
> Signed-off-by: Stefan Beller <sbeller@google.com>

This looks like a good change to me.

Minor nit: the comma after "C" in your commit message is extraneous. ;)

-Peff