git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] auto gc: don't write bitmaps for incremental repacks

From
Jeff King <peff@peff.net>
Date
Dec 23, 2016, 22:12 UTC
Message-ID
<20161223221251.2x5aykpuj6p2kvoh@sigill.intra.peff.net>
In-Reply-To
<1482522215-13401-1-git-send-email-dturner@twosigma.com>
On Fri, Dec 23, 2016 at 02:43:34PM -0500, David Turner wrote:
Show 5 quoted lines
> When git gc --auto does an incremental repack of loose objects, we do
> not expect to be able to write a bitmap; it is very likely that
> objects in the new pack will have references to objects outside of the
> pack.  So we shouldn't try to write a bitmap, because doing so will
> likely issue a warning.

Makes sense. Another reason is that the bitmap-reading code only handles a single bitmap. So it makes sense only to generate one during the all-in-one repack. I don't know if that is worth mentioning.

> Signed-off-by: David Turner <dturner@twosigma.com>
> Signed-off-by: Jeff King <peff@peff.net>

I don't remember if I signed off the original, but just for the record, my signoff here is valid.

-Peff
Previous: Junio C Hamano
Message 5 of 5 in “auto gc: don't write bitmaps for incremental repacks”
  1. 1/2 auto gc: don't write bitmaps for incremental repacksDavid Turner, Dec 23, 2016
  2. 2/2 repack: die on incremental + write-bitmap-indexDavid Turner, Dec 23, 2016
  3. Jeff KingDec 23, 2016
  4. Junio C HamanoDec 23, 2016
  5. Jeff KingDec 23, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.