From: Jeff King <peff@peff.net>
Date: Fri, 23 Dec 2016 22:12:51 GMT
Subject: Re: [PATCH v2 1/2] auto gc: don't write bitmaps for incremental repacks
Message-ID: <20161223221251.2x5aykpuj6p2kvoh@sigill.intra.peff.net>
In-Reply-To: <1482522215-13401-1-git-send-email-dturner@twosigma.com>

On Fri, Dec 23, 2016 at 02:43:34PM -0500, David Turner wrote:

> When git gc --auto does an incremental repack of loose objects, we do
> not expect to be able to write a bitmap; it is very likely that
> objects in the new pack will have references to objects outside of the
> pack.  So we shouldn't try to write a bitmap, because doing so will
> likely issue a warning.

Makes sense. Another reason is that the bitmap-reading code only handles
a single bitmap. So it makes sense only to generate one during the
all-in-one repack. I don't know if that is worth mentioning.

> Signed-off-by: David Turner <dturner@twosigma.com>
> Signed-off-by: Jeff King <peff@peff.net>

I don't remember if I signed off the original, but just for the record,
my signoff here is valid.

-Peff