git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config.c: handle error case for fstat() calls

From
Duy Nguyen <pclouds@gmail.com>
Date
Dec 20, 2016, 09:47 UTC
Message-ID
<20161220094746.GA3917@ash>
In-Reply-To
<xmqqtw9zpz0c.fsf@gitster.mtv.corp.google.com>
On Mon, Dec 19, 2016 at 10:14:27AM -0800, Junio C Hamano wrote:
Show 5 quoted lines
> Shouldn't the error-return path in the second hunk rollback the
> lockfile to clean after itself?  The existing "Oh, we cannot chmod
> to match the original" check that comes immediately after shares the
> same issue, so this is not a new problem, but making an existing one
> worse.

OK. How about two more patches on top (or bottom, does not matter)? The second one should fix this. The first is sort of "good to do".

[PATCH 1/2] config.c: rename label unlock_and_out [PATCH 2/2] config.c: handle lock file in error case in git_config_rename_... -- Duy

Previous: Junio C HamanoNext: Nguyễn Thái Ngọc Duy
Message 4 of 7 in “Segfault in git_config_set_multivar_in_file_gently with direct_io in FUSE filesystem”
  1. Josh Bleecher SnyderDec 16, 2016
  2. config.c: handle error case for fstat() callsNguyễn Thái Ngọc Duy, Dec 19, 2016
  3. Junio C HamanoDec 19, 2016
  4. Duy NguyenDec 20, 2016
  5. 1/2 config.c: rename label unlock_and_outNguyễn Thái Ngọc Duy, Dec 20, 2016
  6. 2/2 config.c: handle lock file in error case in git_config_rename_...Nguyễn Thái Ngọc Duy, Dec 20, 2016
  7. Junio C HamanoDec 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.