Re: [PATCH v3] gitk: Fix missing commits when using -S or -G

From: Paul Mackerras <paulus@ozlabs.org>
Date: Dec 12, 2016, 00:39 UTC
Message-ID: <20161212003919.GE18316@fergus.ozlabs.ibm.com>
In-Reply-To: <1f857709-3c47-d4a1-b858-3288347416f8@gmx.de>

On Sat, Jun 04, 2016 at 10:47:16AM +0200, Stefan Dotterweich wrote:

Show 13 quoted lines

> When -S or -G is used as a filter option, the resulting commit list
> rarely contains all matching commits. Only a certain number of commits
> are displayed and the rest are missing.
> 
> "git log --boundary -S" does not return as many boundary commits as you
> might expect. gitk makes up for this in closevargs() by adding missing
> parent (boundary) commits. However, it does not change $numcommits,
> which limits how many commits are shown. In the end, some commits at the
> end of the commit list are simply not shown.
> 
> Change $numcommits whenever a missing parent is added.
> 
> Signed-off-by: Stefan Dotterweich <stefandotterweich@gmx.de>

Thanks, applied, with slight tweaks to the commit message.

Paul.