Re: [PATCH v2] gitk: Fix missing commits when using -S or -G

From: Paul Mackerras <paulus@ozlabs.org>
Date: May 9, 2016, 03:45 UTC
Message-ID: <20160509034519.GC12515@fergus.ozlabs.ibm.com>
In-Reply-To: <572C8B36.2000106@gmx.de>

On Fri, May 06, 2016 at 02:16:54PM +0200, Stefan Dotterweich wrote:

Show 11 quoted lines

> When -S or -G is used as a filter option, the resulting commit list
> rarely contains all matching commits. Only a certain number of commits
> are displayed and the rest are missing.
> 
> "git log --boundary -S" does not return as many boundary commits as you
> might expect. gitk makes up for this in closevargs() by adding missing
> parent (boundary) commits. However, it does not change $numcommits,
> which limits how many commits are shown. In the end, some commits at the
> end of the commit list are simply not shown.
> 
> Change $numcommits whenever a missing parent is added.

Nice catch; however, we should only update numcommits if the commits are for the current view, i.e. if $v == $curview.

Do you want to update the patch? If you prefer, I can update the patch and put a note in the commit message about the issue.

Paul.