Re: [PATCH] stash: disable renames when calling git-diff

From: Jeff King <peff@peff.net>
Date: Dec 6, 2016, 20:26 UTC
Message-ID: <20161206202649.kqpm3daiucs7zcdr@sigill.intra.peff.net>
In-Reply-To: <xmqq37i024fy.fsf@gitster.mtv.corp.google.com>

On Tue, Dec 06, 2016 at 12:22:25PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I think you are right that diff-index could work, though. I always
> > forget that without "--cached", diff-index looks at the working tree
> > files.
> 
> I'll reword the log message while queuing.  It was super surprising
> to me to hear that there was something "git diff" did that three
> "git diff-*" plumbing brothers couldn't do at the basic "what to
> compare with what" level, as I wrote all four ;-)

Oops, our emails just crossed; I just sent a revised patch.

I know there are a few cases that git-diff can handle that the others can't, but I think they are all direct blob-to-blob comparisons.

-Peff