Re: [PATCH] stash: disable renames when calling git-diff

From: Jeff King <peff@peff.net>
Date: Dec 6, 2016, 20:11 UTC
Message-ID: <20161206201130.azfmqvtk3iettlx7@sigill.intra.peff.net>
In-Reply-To: <xmqqd1h425vv.fsf@gitster.mtv.corp.google.com>

On Tue, Dec 06, 2016 at 11:51:16AM -0800, Junio C Hamano wrote:

Show 9 quoted lines

> > I don't think there's a plumbing command which works for diffing the
> > working tree directly to a git tree. In the long run, it might be a good
> > idea to remedy that.
> 
> I do not think that one is doing anything different from "git
> diff-index --name-only -z HEAD".
> [...]
> Yeah, it looks like "add -u" to me, too.  Perhaps the script was old
> enough that it didn't exist back then?  I dunno.

Hmm, nope. It _was_ "git add -u" at one point and switched. See 7aa5d43cc (stash: Don't overwrite files that have gone from the index, 2010-04-18).

I think you are right that diff-index could work, though. I always forget that without "--cached", diff-index looks at the working tree files.

-Peff