Re: [PATCH] doc: fill in omitted word

From: Jeff King <peff@peff.net>
Date: Nov 10, 2016, 23:06 UTC
Message-ID: <20161110230605.pwgzhai6xhud7pnu@sigill.intra.peff.net>
In-Reply-To: <xmqqd1i356ql.fsf@gitster.mtv.corp.google.com>

On Thu, Nov 10, 2016 at 02:07:30PM -0800, Junio C Hamano wrote:

Show 21 quoted lines

> Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com> writes:
> 
> > Signed-off-by: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com>
> > ---
> >  Documentation/gitcore-tutorial.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt
> > index 4546fa0..9860517 100644
> > --- a/Documentation/gitcore-tutorial.txt
> > +++ b/Documentation/gitcore-tutorial.txt
> > @@ -25,7 +25,7 @@ you want to understand Git's internals.
> >  The core Git is often called "plumbing", with the prettier user
> >  interfaces on top of it called "porcelain". You may not want to use the
> >  plumbing directly very often, but it can be good to know what the
> > -plumbing does for when the porcelain isn't flushing.
> > +plumbing does for you when the porcelain isn't flushing.
> 
> I need an English teacher here to help me out, but I think this
> changes the meaning of the sentence from what the original author
> intended..

It does. I'd take the original to mean "for the case when", which is correct (though as you note, just dropping "for" says the same thing more succinctly).

-Peff