Re: [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS

From: Jeff King <peff@peff.net>
Date: Nov 10, 2016, 16:10 UTC
Message-ID: <20161110161012.jube4bwbww2wa2ew@sigill.intra.peff.net>
In-Reply-To: <CBAF806C-7E1E-4490-A07C-F98DB7488F5F@gmail.com>

On Thu, Nov 10, 2016 at 12:07:14PM +0100, Lars Schneider wrote:

Show 14 quoted lines

> > Using Apache in the tests has been the source of frequent portability
> > problems and configuration headaches. I do wonder if we'd be better off
> > using some small special-purpose web server (even a short perl script
> > written around HTTP::Server::Simple or something).
> > 
> > On the other hand, testing against Apache approximates a more real-world
> > case, which has value. It might be nice if our tests supported multiple
> > web servers, but that would mean duplicating the config for each
> > manually.
> 
> I agree that the real-world Apache test is more valuable and I really want
> to keep the Linux Apache test running. However, I don't think many people
> use macOS as Git web server and therefore I thought it is not worth the
> effort to investigate this problem further.

IMHO, the value in the http tests is not testing the server side, but the client side. Without being able to set up a dummy HTTP server, we do not have any way to exercise the client side of git-over-http at all. And people on macOS _do_ use that. :)

-Peff