Re: [PATCH v1 1/2] config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11

From: Jeff King <peff@peff.net>
Date: Nov 7, 2016, 17:26 UTC
Message-ID: <20161107172617.tlcrpwbjy2w7aoyc@sigill.intra.peff.net>
In-Reply-To: <8C67FF53-C26F-4993-908F-A5183C5E48D9@gmail.com>

On Sun, Nov 06, 2016 at 08:35:04PM +0100, Lars Schneider wrote:

Show 17 quoted lines

> Good point. I think I found an even easier way to achieve the same.
> What do you think about the patch below?
>
> [...]
>
> diff --git a/Makefile b/Makefile
> index 9d6c245..f53fcc9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1047,6 +1047,7 @@ ifeq ($(uname_S),Darwin)
>  		endif
>  	endif
>  	ifndef NO_APPLE_COMMON_CRYPTO
> +		NO_OPENSSL = YesPlease
>  		APPLE_COMMON_CRYPTO = YesPlease
>  		COMPAT_CFLAGS += -DAPPLE_COMMON_CRYPTO
>  	endif

That is much simpler.

I have in the back of my mind a fear that it is harder to unset a make variable than it is to override it with a new value (which is what you'd want to do here to turn openssl back on), but I can't seem to come up with a case that doesn't work. So I am probably misremembering, or just thinking of something that used to be a problem long ago.

-Peff