git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diffcore-delta: remove unused parameter to diffcore_count_changes()

From
Jeff King <peff@peff.net>
Date
Nov 4, 2016, 16:37 UTC
Message-ID
<20161104163714.zwzfbmrklzwuaw6u@sigill.intra.peff.net>
In-Reply-To
<20161104102436.23892-1-tklauser@distanz.ch>
On Fri, Nov 04, 2016 at 11:24:36AM +0100, Tobias Klauser wrote:
> The delta_limit parameter to diffcore_count_changes() has been unused
> since commit c06c79667c95 ("diffcore-rename: somewhat optimized.").
> Remove the parameter and adjust all callers.

Sounds like a good idea to get rid of an unused parameter, but I think this went away in ba23bbc8e (diffcore-delta: make change counter to byte oriented again., 2006-03-04).

The patch itself looks good.
-Peff
Previous: Tobias KlauserNext: Tobias Klauser
Message 2 of 3 in “diffcore-delta: remove unused parameter to diffcore_count_changes()”
  1. diffcore-delta: remove unused parameter to diffcore_count_changes()Tobias Klauser, Nov 4, 2016
  2. Jeff KingNov 4, 2016
  3. Tobias KlauserNov 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.