From: Jeff King Date: Fri, 04 Nov 2016 16:37:14 GMT Subject: Re: [PATCH] diffcore-delta: remove unused parameter to diffcore_count_changes() Message-ID: <20161104163714.zwzfbmrklzwuaw6u@sigill.intra.peff.net> In-Reply-To: <20161104102436.23892-1-tklauser@distanz.ch> On Fri, Nov 04, 2016 at 11:24:36AM +0100, Tobias Klauser wrote: > The delta_limit parameter to diffcore_count_changes() has been unused > since commit c06c79667c95 ("diffcore-rename: somewhat optimized."). > Remove the parameter and adjust all callers. Sounds like a good idea to get rid of an unused parameter, but I think this went away in ba23bbc8e (diffcore-delta: make change counter to byte oriented again., 2006-03-04). The patch itself looks good. -Peff