git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] convert.c: stream and fast search for binary

From
Torsten Bögershausen <tboegi@web.de>
Date
Nov 1, 2016, 09:36 UTC
Message-ID
<20161101093641.GA1313@tb-raspi>
In-Reply-To
<xmqqd1il5w4e.fsf@gitster.mtv.corp.google.com>
[]
Show 15 quoted lines
> This probably should be done as four more patches to become
> reviewable.
> 
>  - One to use the CONVERT_STAT_BITS a lot more for the conversion
>    decision than before, 
> 
>  - another to allow the caller to tell gather_stats() to give up
>    early with the "search_only" bits, 
> 
>  - another to update the get_*_convert_stats() functions to use
>    get_convert_stats_sha1(), and then finally 
> 
>  - use the streaming interface when reading from blob and file.
> 
> or something line that.

Many thanks for the detailed review. Let's see if I can come up with a better series the next weeks or so.

Previous: Junio C HamanoNext: Duy Nguyen
Message 10 of 11 in “convert: stream and early out”
  1. 0/2 convert: stream and early outtboegi@web.de, Oct 9, 2016
  2. Junio C HamanoOct 10, 2016
  3. 1/2 read-cache: factor out get_sha1_from_index() helpertboegi@web.de, Oct 12, 2016
  4. Junio C HamanoOct 27, 2016
  5. Duy NguyenOct 29, 2016
  6. 0/2 Stream and fast searchtboegi@web.de, Oct 12, 2016
  7. Junio C HamanoOct 27, 2016
  8. 2/2 convert.c: stream and fast search for binarytboegi@web.de, Oct 12, 2016
  9. Junio C HamanoOct 27, 2016
  10. Torsten BögershausenNov 1, 2016
  11. Duy NguyenOct 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.