Re: [PATCH v2 2/2] convert.c: stream and fast search for binary
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Nov 1, 2016, 09:36 UTC
- Message-ID
- <20161101093641.GA1313@tb-raspi>
- In-Reply-To
- <xmqqd1il5w4e.fsf@gitster.mtv.corp.google.com>
[]
Show 15 quoted lines
> This probably should be done as four more patches to become > reviewable. > > - One to use the CONVERT_STAT_BITS a lot more for the conversion > decision than before, > > - another to allow the caller to tell gather_stats() to give up > early with the "search_only" bits, > > - another to update the get_*_convert_stats() functions to use > get_convert_stats_sha1(), and then finally > > - use the streaming interface when reading from blob and file. > > or something line that.
Many thanks for the detailed review. Let's see if I can come up with a better series the next weeks or so.