Re: [PATCH 7/7] setup_git_env: avoid blind fall-back to ".git"

From: Jeff King <peff@peff.net>
Date: Oct 26, 2016, 12:31 UTC
Message-ID: <20161026123156.g76z66rxxlkwosht@sigill.intra.peff.net>
In-Reply-To: <CACsJy8AHMJ7OJFKyjYAsPuT0nG=e0RGn59PuX06PJ5pYjinsqA@mail.gmail.com>

On Wed, Oct 26, 2016 at 07:26:20PM +0700, Duy Nguyen wrote:

Show 11 quoted lines

> > I'm not sure this is really any convenience over dumping a corefile
> > and using gdb to pull out the
> > symbols after the fact.
> 
> So are we back to forcing core files? I'm ok with that! The only
> inconvenience I see is pointing out where the core file is, which
> should be where `pwd` originally is. On linux we can even peek into
> /proc/sys/kernel/core_pattern if we want to be precise. ulimit can get
> in the way, but I don't if the default out there is enable or disable
> core dumping. Once we got OS info and git version, our chances of
> cracking the core files should be reasonably high.

TBH, most of the time I expect the solution to be walking the person through:

  git clone git://kernel.org/pub/scm/git/git.git
  cd git
  make

  gdb --args ./git whatever
  break die
  run
  bt

which would cover most cases (reproducible breakage, and not in a sub-program). It's relatively rare that even I resort to corefiles.

-Peff