Re: What's cooking in git.git (Oct 2016, #04; Mon, 17)

From: Jeff King <peff@peff.net>
Date: Oct 19, 2016, 21:21 UTC
Message-ID: <20161019212102.ibzkvutzjjq7yjom@sigill.intra.peff.net>
In-Reply-To: <20161019202856.7ld3kpsnjwu6dbwl@vauxhall.crustytoothpaste.net>

On Wed, Oct 19, 2016 at 08:28:56PM +0000, brian m. carlson wrote:

Show 13 quoted lines

> On Wed, Oct 19, 2016 at 03:46:48AM -0400, Jeff King wrote:
> > FWIW, I gave it a fairly thorough read-over (something I'd been meaning
> > to do for quite a while, but kept never quite getting around to). I
> > think overall it is OK for next. I did find one or two nits, but I think
> > they are things we can fix up in-tree if and when they become a problem
> > (e.g., I noticed that test-genrandom gets piped to "perl -pe". I'm not
> > sure if perl will complain about funny multibyte characters on some
> > systems. I suggest we ignore it until somebody demonstrates that it
> > actually matters).
> 
> I just looked, and that use is fine.  perl -pe is always going to treat
> its data as bytes unless you use -C or explicitly enable Unicode
> functionality.

Thanks. I have vague memories of multibyte warnings, but I think they may have been on _output_ when passing through binary data that came on stdin.

-Peff