Re: What's cooking in git.git (Oct 2016, #04; Mon, 17)
- From
Jeff King <peff@peff.net>
- Date
- Oct 19, 2016, 07:46 UTC
- Message-ID
- <20161019074648.nuk2c2mpvmedjrhb@sigill.intra.peff.net>
- In-Reply-To
- <xmqq4m49pffk.fsf@gitster.mtv.corp.google.com>
On Tue, Oct 18, 2016 at 01:31:27PM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> >> * ls/filter-process (2016-10-17) 14 commits > [...] > > what do you think about v11? Do you feel the series is becoming mature > > enough for `next`? > > I've already had that feeling a few rounds ago, but I haven't had a > chance to read the most recent one carefully myself to answer that > question honestly.
FWIW, I gave it a fairly thorough read-over (something I'd been meaning to do for quite a while, but kept never quite getting around to). I think overall it is OK for next. I did find one or two nits, but I think they are things we can fix up in-tree if and when they become a problem (e.g., I noticed that test-genrandom gets piped to "perl -pe". I'm not sure if perl will complain about funny multibyte characters on some systems. I suggest we ignore it until somebody demonstrates that it actually matters).
-Peff