Re: [PATCH v4 6/7] t/t7030-verify-tag: Add --format specifier tests

From: Jeff King <peff@peff.net>
Date: Oct 19, 2016, 09:13 UTC
Message-ID: <20161019091323.jrirwruwex7l7yj2@sigill.intra.peff.net>
In-Reply-To: <20161007210721.20437-7-santiago@nyu.edu>

On Fri, Oct 07, 2016 at 05:07:20PM -0400, santiago@nyu.edu wrote:

> Verify-tag now provides --format specifiers to inspect and ensure the
> contents of the tag are proper. We add two tests to ensure this
> functionality works as expected: the return value should indicate if
> verification passed, and the format specifiers must be respected.

Sounds good.

Show 7 quoted lines

> +test_expect_success 'verifying tag with --format' '
> +	cat >expect <<-\EOF &&
> +	tagname : fourth-signed
> +	EOF
> +	git verify-tag --format="tagname : %(tag)" "fourth-signed" >actual &&
> +	test_cmp expect actual
> +'

I suppose it's a matter of style, but for a single-line expectation I would just do:

  echo "tagname : fourth-signed" >expect &&

which is shorter and saves a process invocation.

Ditto on the next patch (which IMHO could just be squashed into a single patch).

-Peff