git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 1/7] gpg-interface, tag: add GPG_VERIFY_QUIET flag

From
Jeff King <peff@peff.net>
Date
Oct 19, 2016, 08:51 UTC
Message-ID
<20161019085115.thvsf5muhyvmvgj2@sigill.intra.peff.net>
In-Reply-To
<20161007210721.20437-2-santiago@nyu.edu>
On Fri, Oct 07, 2016 at 05:07:15PM -0400, santiago@nyu.edu wrote:
Show 5 quoted lines
> From: Lukas Puehringer <luk.puehringer@gmail.com>
> 
> Functions that print git object information may require that the
> gpg-interface functions be silent. Add GPG_VERIFY_QUIET flag and prevent
> print_signature_buffer from being called if flag is set.

The layering here is a little funny. The gpg-interface code allocates a new flag, but none of its functions do anything with it. Instead, it's acted on only by the run_gpg_verify() command local to tag.c.

I guess this "flags" variable comes to us from other callsites via gpg_verify_tag. That's still in tag.c, but it's arguably part of the gpg interface.

So I think it's OK.
-Peff
Previous: santiago@nyu.eduNext: santiago@nyu.edu
Message 10 of 16 in “Add --format to tag verification”
  1. 0/7 Add --format to tag verificationsantiago@nyu.edu, Oct 7, 2016
  2. 2/7 ref-filter: add function to print single ref_array_itemsantiago@nyu.edu, Oct 7, 2016
  3. Jeff KingOct 19, 2016
  4. Jeff KingOct 19, 2016
  5. Santiago TorresOct 19, 2016
  6. 4/7 builtin/verify-tag: add --format to verify-tagsantiago@nyu.edu, Oct 7, 2016
  7. Jeff KingOct 19, 2016
  8. 3/7 tag: add format specifier to gpg_verify_tagsantiago@nyu.edu, Oct 7, 2016
  9. 1/7 gpg-interface, tag: add GPG_VERIFY_QUIET flagsantiago@nyu.edu, Oct 7, 2016
  10. Jeff KingOct 19, 2016
  11. 5/7 builtin/tag: add --format argument for tag -vsantiago@nyu.edu, Oct 7, 2016
  12. Jeff KingOct 19, 2016
  13. 6/7 t/t7030-verify-tag: Add --format specifier testssantiago@nyu.edu, Oct 7, 2016
  14. Jeff KingOct 19, 2016
  15. 7/7 t/t7004-tag: Add --format specifier testssantiago@nyu.edu, Oct 7, 2016
  16. Santiago TorresOct 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.