Re: [PATCH 5/5] log: add --commit-header option

From: Jeff King <peff@peff.net>
Date: Sep 29, 2016, 18:31 UTC
Message-ID: <20160929183127.4ptf2dqdeo67avte@sigill.intra.peff.net>
In-Reply-To: <xmqqtwcyfvfz.fsf@gitster.mtv.corp.google.com>

On Thu, Sep 29, 2016 at 10:49:04AM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > This lets you stick a header right before a commit, but
> > suppresses headers that are duplicates. This means you can
> > do something like:
> >
> >   git log --graph --author-date-order --commit-header='== %as =='
> >
> > to get a marker in the graph whenever the day changes.
> 
> That's interesting.  So it is not really "commit" header, but a
> header for groups of commits.  Credits for realizing the usefulness
> of such grouping may go to Kyle, but the implementation is also
> brilliant ;-).

Yeah, I really don't like the name "--commit-header" that much. I initially thought to call it "--graph-header", but it is potentially useful without a graph, too. Maybe "--group-header" or something. I dunno. I'd leave that to somebody who actually wanted to polish the patches up enough for submission. That might even be me someday, but not today. :)

-Peff