Re: [PATCH 2/5] pretty: allow formatting names as initials
- From
Jeff King <peff@peff.net>
- Date
- Sep 29, 2016, 17:32 UTC
- Message-ID
- <20160929173239.c62vv3gtdoz3r6ij@sigill.intra.peff.net>
- In-Reply-To
- <xmqq37kihatp.fsf@gitster.mtv.corp.google.com>
On Thu, Sep 29, 2016 at 10:31:30AM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> > When I first tested it with "git log --format=%aS" I had to wonder "who > > the heck is ntnd?". So using only the first-and-last would match the git > > project's practice better, at least. > > And there is also "isalpha() good enough?" question. > > I think we have a few Chinese and Hangul as well as Cyrillic names > in our history, some of them having outside-ascii first letters. > One of the more prolific contributor's initial is ÆAB ;-)
Heh, true. In case it was not clear, these were mostly quick-and-dirty patches. I think the right test is probably '!isspace()".
-Peff